Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.12 Cabal changelog #9785

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add 3.12 Cabal changelog #9785

merged 1 commit into from
Mar 7, 2024

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Mar 7, 2024

Add release notes for Cabal 3.12.


Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • no CI fix Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what to do with the cabal-install changelog, given that we don't release cabal-install in 3.12.0, only later on, when it stabilises, in 3.12.1. Maybe wipe out the cabal-install/changelog changes, but keep all the rest of the work you've done, marking the top of release-notes/cabal-install-3.12.0.0.md as "cabal-install-3.12.1.0 WIP changelog" and renaming the file (either to cabal-install-3.12.1.0.md or cabal-install-3.12.1.0.WIP.md to avoid confusions). Any better ideas?

Cabal/ChangeLog.md Outdated Show resolved Hide resolved
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Mar 7, 2024

I wonder what to do with the cabal-install changelog, given that we don't release cabal-install in 3.12.0, only later on, when it stabilises, in 3.12.1

Yeah I was going to ask. My initial idea was “who cares, we are not releasing artifacts, but of course having a release file without a release will cause confusion. I will move it to a WIP file for now.

@ffaf1 ffaf1 marked this pull request as ready for review March 7, 2024 12:43
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

release-notes/WIP-cabal-install-3.12.0.0.md Outdated Show resolved Hide resolved
@ffaf1 ffaf1 force-pushed the 3.12-changelog branch 2 times, most recently from 2b205a2 to 4b1fa80 Compare March 7, 2024 14:15
@ffaf1 ffaf1 added the merge me Tell Mergify Bot to merge label Mar 7, 2024
@ffaf1 ffaf1 changed the title 3.12 changelog Add 3.12 Cabal changelog Mar 7, 2024
- generated with
     git log --pretty=oneline --no-color cabal-install-v3.10.1.0..HEAD > 3.12.prlog
- deduped
- stored WIP “release notes” file for future `cabal-install` release
@mergify mergify bot merged commit 880831f into haskell:3.12 Mar 7, 2024
54 checks passed
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Mar 7, 2024

@mergify backport master

Copy link
Contributor

mergify bot commented Mar 7, 2024

backport master

✅ Backports have been created

@ffaf1 ffaf1 deleted the 3.12-changelog branch March 7, 2024 19:29
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Mar 9, 2024
ffaf1 added a commit to ffaf1/cabal that referenced this pull request Apr 23, 2024
Forwardport of haskell#9785, haskell#9908

Add changelog/release notes for Cabal 3.12 (haskell#9785)

- generated with
     git log --pretty=oneline --no-color cabal-install-v3.10.1.0..HEAD > 3.12.prlog
- deduped
- stored WIP “release notes” file for future `cabal-install` release

3.12 changelogs updated (haskell#9908)

* Update changelog for 3.12

(and for future WIP 3.12.1.0 cabal-install)

* Remove changelog.d files
@ffaf1 ffaf1 mentioned this pull request Apr 23, 2024
2 tasks
ffaf1 added a commit to ffaf1/cabal that referenced this pull request Apr 23, 2024
Forwardport of haskell#9785, haskell#9908

Add changelog/release notes for Cabal 3.12 (haskell#9785)

- generated with
     git log --pretty=oneline --no-color cabal-install-v3.10.1.0..HEAD > 3.12.prlog
- deduped
- stored WIP “release notes” file for future `cabal-install` release

3.12 changelogs updated (haskell#9908)

* Update changelog for 3.12

(and for future WIP 3.12.1.0 cabal-install)

* Remove changelog.d files
Mikolaj pushed a commit to ffaf1/cabal that referenced this pull request Apr 25, 2024
Forwardport of haskell#9785, haskell#9908

Add changelog/release notes for Cabal 3.12 (haskell#9785)

- generated with
     git log --pretty=oneline --no-color cabal-install-v3.10.1.0..HEAD > 3.12.prlog
- deduped
- stored WIP “release notes” file for future `cabal-install` release

3.12 changelogs updated (haskell#9908)

* Update changelog for 3.12

(and for future WIP 3.12.1.0 cabal-install)

* Remove changelog.d files
mergify bot pushed a commit that referenced this pull request Apr 25, 2024
* Add release notes for Cabal 3.12

Forwardport of #9785, #9908

Add changelog/release notes for Cabal 3.12 (#9785)

- generated with
     git log --pretty=oneline --no-color cabal-install-v3.10.1.0..HEAD > 3.12.prlog
- deduped
- stored WIP “release notes” file for future `cabal-install` release

3.12 changelogs updated (#9908)

* Update changelog for 3.12

(and for future WIP 3.12.1.0 cabal-install)

* Remove changelog.d files

* 3.12 changelog fixup (#9922)

* Incorporate Brandon’s suggestions

See #9920.

* Incorporate Artem’s suggestions

See #9920.

* Do not repeat yourself

* Fix whitespace

* Fix release notes grammar

See #9920.
fendor pushed a commit to fendor/cabal that referenced this pull request Apr 30, 2024
* Add release notes for Cabal 3.12

Forwardport of haskell#9785, haskell#9908

Add changelog/release notes for Cabal 3.12 (haskell#9785)

- generated with
     git log --pretty=oneline --no-color cabal-install-v3.10.1.0..HEAD > 3.12.prlog
- deduped
- stored WIP “release notes” file for future `cabal-install` release

3.12 changelogs updated (haskell#9908)

* Update changelog for 3.12

(and for future WIP 3.12.1.0 cabal-install)

* Remove changelog.d files

* 3.12 changelog fixup (haskell#9922)

* Incorporate Brandon’s suggestions

See haskell#9920.

* Incorporate Artem’s suggestions

See haskell#9920.

* Do not repeat yourself

* Fix whitespace

* Fix release notes grammar

See haskell#9920.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants